Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing styles fix #205

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
330062b
Channel setting's additional options and edit message retention modal
Jan 11, 2019
65bd4ba
search modal files list missing style fix
Jan 11, 2019
0753275
Merge branch 'master' into scss-dev
May 27, 2019
105570c
preference modal missing style added
May 27, 2019
9163055
select input missing style added
May 27, 2019
416ff45
moved select input style from base to _select.scss
May 27, 2019
79eb688
preference modal link color style added
May 27, 2019
d335caa
missing style added
May 27, 2019
8018777
select input scss file import added
May 27, 2019
33927fa
select input style added
May 27, 2019
eec2187
Threads page missing style added
May 29, 2019
b4c2801
moved threads styling to existing file
May 29, 2019
91e6d70
added missing style for highlight panel in All unreads pane
May 29, 2019
4cac10f
moved threads style to existing file
May 29, 2019
0c21943
Threads pane scrollbar color change
May 29, 2019
cede844
resolved review by @mastermel
May 31, 2019
1831aa5
resolving reviews
May 31, 2019
e50712d
resolved lint reviews
May 31, 2019
7a37a35
resolving lint reviews
May 31, 2019
228be65
post message checklist background fix
Jul 12, 2019
c00194e
header and message line color fix for >4.0
Jul 26, 2019
3984b1f
missing style add for > 4.0
Jul 26, 2019
dc1d420
style change
Jul 26, 2019
40a760a
download flexpane body background change
Jul 26, 2019
c379ad0
file upload dialog missing style
Jul 29, 2019
bc11e63
channel pinned item style fix v4
Jul 30, 2019
c316bf2
channel highlights date label style fix v4
Jul 30, 2019
0aa9ccc
member tooltip style fix v4
Jul 30, 2019
3b37e9d
resolved houndci-bot reviews
Jul 30, 2019
6e4e154
sass lint resolve
Jul 30, 2019
3683e08
resolve lint
Jul 30, 2019
d9a15bd
remove trailing whitespace
Jul 30, 2019
c007fcd
All unreads tab missing style fix
Jul 30, 2019
476f4cb
all unreads missing style added
Jul 30, 2019
25e3345
mentions' auto complete missing style for v4
Aug 8, 2019
ca80d08
DM modal missing style fix
Aug 9, 2019
360ef92
unreads view class background change
Aug 12, 2019
d4fc43d
unreads empty missing style fix
Aug 12, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scss/modules/flexpane/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,5 @@
}

#client_body:not(.onboarding):not(.feature_global_nav_layout):before {
background: $color-shade-dark;
background: $color-base;
}
4 changes: 4 additions & 0 deletions scss/modules/header/_search.scss
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,7 @@
.c-search__input_and_close__close {
color: $base-font-color;
}

.c-pillow_file_container {
background: $color-base;
}
14 changes: 13 additions & 1 deletion scss/modules/inputs/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,18 @@ textarea {
}
}

.c-input_textarea {
border: 1px solid $color-shade-darkest;
This conversation was marked as resolved.
Show resolved Hide resolved
color: $base-font-color;
background: $color-shade-light;

&:active,
&:focus {
border-color: $color-shade-dark;
box-shadow: 0 0 7px rgba($color-shade-lightest, 0.15);
}
}

input:disabled,
input:disabled:active,
select:disabled,
Expand Down Expand Up @@ -347,4 +359,4 @@ textarea {
.ql-placeholder {
color: $base-font-color;
}
}
}
This conversation was marked as resolved.
Show resolved Hide resolved
7 changes: 7 additions & 0 deletions scss/modules/inputs/_messaging.scss
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,13 @@
&__warning {
color: $color-red;
}

This conversation was marked as resolved.
Show resolved Hide resolved
&__emoji_happy_icon,
This conversation was marked as resolved.
Show resolved Hide resolved
&__emoji_smile_icon,
&__emoji_circle_icon {
color: rgba($base-font-color, 0.3);
}

}

.c-button {
Expand Down
31 changes: 31 additions & 0 deletions scss/modules/inputs/_select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,34 @@
color: $base-font-color;
}
}

.c-select_button {
background: $color-shade-light;

&:active {
background: $color-shade-dark;
}

&__icon, &:hover, &:hover .c-select_button__icon {
This conversation was marked as resolved.
Show resolved Hide resolved
color: $white;
}

&:focus {
box-shadow: 0 0 0 1px $white, 0 0 0 5px $color-shadow-transparent;
}
}

.c-select_options_list {
&__wrapper {
background-color: $color-shade-light;
}

&__option {
color: $color-highlight;

&--selected {
color: $base-font-color;
}

}
}
This conversation was marked as resolved.
Show resolved Hide resolved
48 changes: 48 additions & 0 deletions scss/modules/messaging/_threads.scss
Original file line number Diff line number Diff line change
Expand Up @@ -146,3 +146,51 @@ ts-thread .thread_participants {
color: $color-highlight;
}
}

.p-threads_view_root,
.p-threads_view_reply,
.p-threads_view__footer {
border-color: $color-shade-mid;
}

.p_threads_view_load_newer_button,
This conversation was marked as resolved.
Show resolved Hide resolved
.p_threads_view_load_older_button {
border-color: $color-shade-mid;
This conversation was marked as resolved.
Show resolved Hide resolved
background: $color-base;
}

.p-threads_view {
background: $color-base;

&__divider_line {
border-color: $color-shade-dark;
}

&__divider_label {
color: $color-highlight;
This conversation was marked as resolved.
Show resolved Hide resolved
background: $color-base;
}

&__default_background {
background: $color-base;
}
}

.p-threads_view_header {
&__channel_name {
color: $base-font-color;
}
}

.p-threads_footer {
&__input--legacy {
.p-message_input_file_button,
.p-message_input_field {
border-color: $color-shade-mid;
}
}
}

.c-scrollbar__bar {
background: rgba($white, .25);
This conversation was marked as resolved.
Show resolved Hide resolved
}
This conversation was marked as resolved.
Show resolved Hide resolved
27 changes: 27 additions & 0 deletions scss/modules/messaging/_unreads.scss
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,30 @@
background: $color-base;
background-image: none;
}

.sli_briefing {
background: $color-base;
}

.sli_briefing_preview {
background-color: $color-base;
border-color: $color-shade-mid;

&__title {
color: $base-font-color;
}

&__description_text {
b {
color: $base-font-color;
}
}
}

.sli_briefing_preview_container {
&::after,
&::before {
border-color: $color-shade-mid;
This conversation was marked as resolved.
Show resolved Hide resolved
background-color: $color-base;
}
}
This conversation was marked as resolved.
Show resolved Hide resolved
29 changes: 29 additions & 0 deletions scss/modules/modals/_base.scss
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,32 @@
background-color: $color-shade-dark;
}
}

.c-fullscreen_modal {
&__content {
background: $color-base;
}

&__header {
background: $color-base;
}

&__body {
color: $base-font-color;
}

&__back,
&__close {
color: rgba($base-font-color, 0.5);

&:hover {
// background: $color-shade-lightest;
This conversation was marked as resolved.
Show resolved Hide resolved
color: $base-font-color;
}

&:active {
// background: $color-shade-lightest;
This conversation was marked as resolved.
Show resolved Hide resolved
color: $base-font-color;
}
}
}
20 changes: 20 additions & 0 deletions scss/modules/modals/_channel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,23 @@
.notification_prefs_icon::before {
color: $base-font-color;
}

.channel_options_modal {
This conversation was marked as resolved.
Show resolved Hide resolved
.c-fullscreen_modal {
&__title {
color: $base-font-color;
}
}
}

.channel_option_item {
border-top-color: $color-shade-dark;

.title {
color: $base-font-color;
}

&:hover {
background: $color-shade-dark;
}
}
36 changes: 36 additions & 0 deletions scss/modules/modals/_preferences.scss
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,39 @@
.jumbomoji_disabled_note {
color: rgba($color-highlight, 0.6);
}

.c-sidebar_menu {
&__list_item {
color: $white;

&.is_active {
This conversation was marked as resolved.
Show resolved Hide resolved
background: $color-shade-light;
border-color: $color-shade-light;
}
}
}

.p-prefs_modal__radiogroup {
label {
&.p-prefs_modal__radiogroup--selected {
background: $color-shade-light;
border-color: $color-shade-light;

.p-prefs_modal__radio_decorator {
background: $color-shade-light;
}
}
}

.p-prefs_modal__radio_decorator {
background: $color-base;
}
}

.c-link--button {
color: $base-link-color;

&:active, &:hover {
This conversation was marked as resolved.
Show resolved Hide resolved
color: $base-link-color-active;
}
}
This conversation was marked as resolved.
Show resolved Hide resolved
3 changes: 2 additions & 1 deletion scss/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
@import "modules/inputs/toggle";
@import "modules/inputs/label";
@import "modules/inputs/datepicker";
@import "modules/inputs/select";

@import "modules/menu/base";
@import "modules/menu/autocomplete";
Expand Down Expand Up @@ -97,4 +98,4 @@
@import "modules/pages/apps";
@import "modules/pages/legal";
@import "modules/pages/oauth";
@import "modules/pages/spaces";
@import "modules/pages/spaces";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline