Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FTableSchema
,FactorizedTableUtils
into their own files.dataChunkPos
out ofColumnSchema
. The previous design simply doesn't make sense. We now maintain this information atFTableSchema
. The high level idea is thatFTableSchema
contains multipleColumnSchema
and also multipleGroup
. EachColumnSchema
belongs to oneGroup
. If multipleColumnSchema
belongs to the sameGroup
then they must share the sameGroup
metadata, i.e. flat information. There is still more work to do, for example we should makeGroupID
consecutive instead of usingDataChunkPos
. But this needs to be done progressively.