Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ftable schema #3479

Merged
merged 1 commit into from May 13, 2024
Merged

Refactor ftable schema #3479

merged 1 commit into from May 13, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented May 13, 2024

  • Split FTableSchema, FactorizedTableUtils into their own files.
  • Move dataChunkPos out of ColumnSchema. The previous design simply doesn't make sense. We now maintain this information at FTableSchema. The high level idea is that FTableSchema contains multiple ColumnSchema and also multiple Group. Each ColumnSchema belongs to one Group. If multiple ColumnSchema belongs to the same Group then they must share the same Group metadata, i.e. flat information. There is still more work to do, for example we should make GroupID consecutive instead of using DataChunkPos. But this needs to be done progressively.
  • Remove unnecessary unique_ptr
  • Protect implicit copy with EXPLICIT_COPY macro.

@andyfengHKU andyfengHKU merged commit e38b01d into master May 13, 2024
18 checks passed
@andyfengHKU andyfengHKU deleted the clear-table-schema branch May 13, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants