[DO NOT REVIEW] Try issue 3166 #3404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
force-pushed
the
try-issue-3166
branch
from
2a406cc
to
e1b2108
Compare
andyfengHKU
force-pushed
the
try-issue-3166
branch
from
d7a5d4f
to
f395a9d
Compare
ray6080
approved these changes
May 10, 2024
| common::RelDataDirection direction; | ||
|
|
||
| // This direction is not |
There was a problem hiding this comment.
Complete the sentence here.
| void StructPackFunctions::undirectedRelPackExecFunc( | ||
| const std::vector<std::shared_ptr<ValueVector>>& parameters, ValueVector& result, void*) { | ||
| KU_ASSERT(parameters.size() > 1); | ||
| // Force copy of |
| @@ -33,6 +33,17 @@ void StructPackFunctions::compileFunc(FunctionBindData* /*bindData*/, | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Better clearly state the implicit assumption of src being 0 and dst being 1 here.
| namespace evaluator { | ||
|
|
||
| class NodeRelExpressionEvaluator final : public ExpressionEvaluator { | ||
| class PatternExpressionEvaluator : public ExpressionEvaluator { |
There was a problem hiding this comment.
Let's also rename the file to pattern_evaluator.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to check this against CI first.