Always build rust integration with release runtime library on Windows #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwinger
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
See #3225 (comment), but I don't have any objections to doing this. As far as I understand it just means we don't get debug symbols for the MSVC runtime library, but would still get them for kuzu itself in debug mode, and I think this is probably a cleaner way of handling it than having to set environment variables.
|
The CI pipeline will need to be updated to remove the environment variables overriding with Additionally, can you add |
|
I have read and agree to the terms under CLA.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3225