Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust value tests #2708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rust value tests #2708

wants to merge 1 commit into from

Conversation

benjaminwinger
Copy link
Collaborator

I've re-enabled some rust tests which had been disabled due to them not being fully supported as they now appear to be working.
Passing unions as parameters still doesn't seem to be supported, however I noticed a change to how union tags are handled which hadn't been propagated to the rust API, so I moved the tag type details into the LogicalType::UNION function to handle them all in one place.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.37%. Comparing base (b491af2) to head (6f52967).
Report is 81 commits behind head on master.

Current head 6f52967 differs from pull request most recent head 5f9f4e7

Please upload reports for the commit 5f9f4e7 to get more accurate results.

Files Patch % Lines
src/common/types/value/nested.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
+ Coverage   92.59%   93.37%   +0.78%     
==========================================
  Files        1205     1073     -132     
  Lines       44825    40432    -4393     
==========================================
- Hits        41504    37754    -3750     
+ Misses       3321     2678     -643     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant