-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: props with children #94
Open
cothvbdnnn
wants to merge
1
commit into
kutlugsahin:master
Choose a base branch
from
cothvbdnnn:fix/props-with-children
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cothvbdnnn
force-pushed
the
fix/props-with-children
branch
from
October 2, 2022 03:19
4e6b141
to
0a054ba
Compare
Can we please get this merged? |
@kutlugsahin fix #88 |
kachar
approved these changes
Mar 21, 2023
parkournick3
approved these changes
Jun 12, 2023
ronaldosenajr
approved these changes
Jun 12, 2023
When will this MR be merged, it blocks the library from being used with typescript. Is this project still maintained? |
@kutlugsahin any progress here? I have this exact issue as well |
JeremyMColegrove
approved these changes
Nov 15, 2023
Can we please have this merged? 💯 |
grahamplace
added a commit
to grahamplace/react-smooth-dnd
that referenced
this pull request
Dec 7, 2023
@JeremyMColegrove any progress ? This lib will be perfect without this bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.