Skip to content

Commit

Permalink
Remove google analytic which is never used, closes #4
Browse files Browse the repository at this point in the history
* But this is nice idea to support script developers and SL4A developer.
* idea: Append tracking if call was failed...etc...
  • Loading branch information
kuri65536 committed Jul 19, 2015
1 parent b979aea commit 0af8c82
Show file tree
Hide file tree
Showing 18 changed files with 18 additions and 128 deletions.
Binary file removed android/Common/libs/libGoogleAnalytics.jar
Binary file not shown.
94 changes: 0 additions & 94 deletions android/Common/src/com/googlecode/android_scripting/Analytics.java

This file was deleted.

Expand Up @@ -19,7 +19,6 @@
import android.content.Intent;
import android.net.Uri;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.facade.AndroidFacade;
import com.googlecode.android_scripting.jsonrpc.RpcReceiver;
import com.googlecode.android_scripting.jsonrpc.RpcReceiverManager;
Expand Down Expand Up @@ -83,7 +82,7 @@ public static Collection<MethodDescriptor> collectFrom(Class<? extends RpcReceiv
*/
public Object invoke(RpcReceiverManager manager, final JSONArray parameters) throws Throwable {
// Issue track call first in case of failure.
Analytics.track("api", getName());
// Analytics.track("api", getName());

final Type[] parameterTypes = getGenericParameterTypes();
final Object[] args = new Object[parameterTypes.length];
Expand Down
Expand Up @@ -16,7 +16,6 @@

package com.googlecode.android_scripting.interpreter;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.AndroidProxy;
import com.googlecode.android_scripting.Log;
import com.googlecode.android_scripting.Process;
Expand Down Expand Up @@ -105,7 +104,7 @@ public RpcReceiverManagerFactory getRpcReceiverManagerFactory() {

@Override
public void start(final Runnable shutdownHook) {
Analytics.track(mInterpreter.getName());
// Analytics.track(mInterpreter.getName());
// NOTE(damonkohler): String.isEmpty() doesn't work on Cupcake.
if (!mCommand.equals("")) {
addArgument(mCommand);
Expand Down
Expand Up @@ -30,8 +30,7 @@ public class Sl4aApplication extends BaseApplication {
@Override
public void onCreate() {
super.onCreate();
// TODO: remove Analytics, it can't be watched for everyone.
Analytics.start(this, "UA-158835-13");
// Analytics.start(this, "UA-158835-13");

// extract run_pie from asset folder.
File path = new File(this.getFilesDir(), "run_pie");
Expand Down Expand Up @@ -71,6 +70,6 @@ else if (run_pie.startsWith("mips")) {

@Override
public void onTerminate() {
Analytics.stop();
// Analytics.stop();
}
}
Expand Up @@ -39,7 +39,6 @@
import com.google.common.base.Predicate;
import com.google.common.collect.Collections2;
import com.google.common.collect.Lists;
import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.BaseApplication;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.Log;
Expand Down Expand Up @@ -98,7 +97,7 @@ public void onCreate(Bundle savedInstanceState) {
mAdapter = new ApiBrowserAdapter();
setListAdapter(mAdapter);
registerForContextMenu(getListView());
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
setResult(RESULT_CANCELED);
}

Expand Down Expand Up @@ -226,7 +225,7 @@ public boolean onContextItemSelected(MenuItem item) {
if (item.getItemId() == ContextMenuId.INSERT_TEXT.getId()) {
// There's no activity to track calls to insert (like there is for prompt) so we track it
// here instead.
Analytics.track("ApiInsert");
// Analytics.track("ApiInsert");
insertText(rpc, new String[0]);
} else if (item.getItemId() == ContextMenuId.PROMPT_PARAMETERS.getId()) {
Intent intent = new Intent(this, ApiPrompt.class);
Expand Down
Expand Up @@ -32,7 +32,6 @@
import android.widget.ListView;
import android.widget.TextView;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.R;
import com.googlecode.android_scripting.facade.FacadeConfiguration;
Expand Down Expand Up @@ -74,7 +73,7 @@ public void onClick(View v) {
finish();
}
});
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
setResult(RESULT_CANCELED);
}

Expand Down
Expand Up @@ -25,7 +25,6 @@
import android.widget.BaseAdapter;
import android.widget.TextView;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.R;
import com.googlecode.android_scripting.bluetooth.BluetoothDiscoveryHelper;
Expand Down Expand Up @@ -55,7 +54,7 @@ protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
CustomizeWindow.requestCustomTitle(this, "Bluetooth Devices", R.layout.bluetooth_device_list);
setListAdapter(mAdapter);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -40,7 +40,6 @@
import android.widget.TextView;

import com.googlecode.android_scripting.ActivityFlinger;
import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.BaseApplication;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.FeaturedInterpreters;
Expand Down Expand Up @@ -85,7 +84,7 @@ public void onCreate(Bundle savedInstanceState) {
ActivityFlinger.attachView(getWindow().getDecorView(), this);
mFeaturedInterpreters = FeaturedInterpreters.getList();
mPreferences = PreferenceManager.getDefaultSharedPreferences(this);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -31,7 +31,6 @@
import android.widget.ListView;
import android.widget.TextView;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.BaseApplication;
import com.googlecode.android_scripting.FeaturedInterpreters;
import com.googlecode.android_scripting.IntentBuilders;
Expand Down Expand Up @@ -65,7 +64,7 @@ public void onCreate(Bundle savedInstanceState) {
mAdapter = new InterpreterPickerAdapter();
mAdapter.registerDataSetObserver(mObserver);
setListAdapter(mAdapter);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -31,7 +31,6 @@
import android.widget.Toast;

import com.googlecode.android_scripting.ActivityFlinger;
import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.Log;
import com.googlecode.android_scripting.Process;
import com.googlecode.android_scripting.R;
Expand Down Expand Up @@ -105,7 +104,7 @@ protected void onCreate(Bundle savedInstanceState) {
setListAdapter(mAdapter);
ActivityFlinger.attachView(getListView(), this);
ActivityFlinger.attachView(getWindow().getDecorView(), this);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -19,7 +19,6 @@
import android.os.Bundle;
import android.preference.PreferenceActivity;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.R;

public class Preferences extends PreferenceActivity {
Expand All @@ -28,6 +27,6 @@ protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
// Load the preferences from an XML resource
addPreferencesFromResource(R.xml.preferences);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}
}
Expand Up @@ -42,7 +42,6 @@
import android.widget.EditText;
import android.widget.Toast;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.BaseApplication;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.FileUtils;
Expand Down Expand Up @@ -161,7 +160,7 @@ protected void onCreate(Bundle savedInstanceState) {
mContentText.requestFocus();
mContentText.setSelection(lastLocation);
}
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -45,7 +45,6 @@
import com.google.common.collect.Collections2;
import com.google.common.collect.Lists;
import com.googlecode.android_scripting.ActivityFlinger;
import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.BaseApplication;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.FileUtils;
Expand Down Expand Up @@ -152,7 +151,7 @@ public void onCreate(Bundle savedInstanceState) {
startService(IntentBuilders.buildTriggerServiceIntent());
handleIntent(getIntent());
UsageTrackingConfirmation.show(this);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -26,7 +26,6 @@
import android.view.View.OnClickListener;
import android.widget.ListView;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.BaseApplication;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.FeaturedInterpreters;
Expand Down Expand Up @@ -66,7 +65,7 @@ public void onCreate(Bundle savedInstanceState) {
mAdapter = new ScriptPickerAdapter(this);
mAdapter.registerDataSetObserver(new ScriptListObserver());
setListAdapter(mAdapter);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -35,7 +35,6 @@
import android.widget.ListView;
import android.widget.TextView;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.Log;
import com.googlecode.android_scripting.R;
Expand Down Expand Up @@ -91,7 +90,7 @@ public void onCreate(Bundle savedInstanceState) {
mAdapter = new ScriptMonitorAdapter();
setListAdapter(mAdapter);
registerForContextMenu(getListView());
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down
Expand Up @@ -8,7 +8,6 @@
import android.os.Bundle;
import android.provider.LiveFolders;

import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.R;
import com.googlecode.android_scripting.provider.ScriptProvider;

Expand All @@ -27,7 +26,7 @@ protected void onCreate(Bundle savedInstanceState) {
} else {
setResult(RESULT_CANCELED);
}
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
finish();
}

Expand Down
Expand Up @@ -35,7 +35,6 @@

import com.google.common.collect.Lists;
import com.googlecode.android_scripting.ActivityFlinger;
import com.googlecode.android_scripting.Analytics;
import com.googlecode.android_scripting.BaseApplication;
import com.googlecode.android_scripting.Constants;
import com.googlecode.android_scripting.Log;
Expand Down Expand Up @@ -85,7 +84,7 @@ protected void onCreate(Bundle savedInstanceState) {
mTriggerRepository.bootstrapObserver(observer);
ActivityFlinger.attachView(getListView(), this);
ActivityFlinger.attachView(getWindow().getDecorView(), this);
Analytics.trackActivity(this);
// Analytics.trackActivity(this);
}

@Override
Expand Down

0 comments on commit 0af8c82

Please sign in to comment.