Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gap in hero section and pagination #3119

Merged
merged 1 commit into from May 12, 2024

Conversation

r7projects-shayan
Copy link
Contributor

PR Description πŸ“œ

Issue Description

There is too much space between the first heading in the website and the games section. This causes inconsistency between the users, since the first thing that they see is a blank website.

I have reduced the extra space and also increased the space in the pagination_section div for better user experience
Fixes #3107


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • My changes generates no new warnings.
  • I have specified the respective issue number for which I have made changes to the website
  • Reduced extra space in the hero(main) section and increased some space in the pagination section

Add your screenshots(Optional) πŸ“Έ

Screenshot 2024-05-11 150623
Screenshot 2024-05-11 150634



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented May 11, 2024

Thank you @r7projects-shayan ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunjgit kunjgit added level1 Documentation and small bug fixes in gssoc gssoc GSSoC24 program label labels May 12, 2024
@kunjgit kunjgit merged commit fd6dfcf into kunjgit:main May 12, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @r7projects-shayan , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: There is too much space between the hero section and the games section
2 participants