Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added event listeners for specific keyboard buttons and implemented the functionality to play music #3111

Merged
merged 1 commit into from May 12, 2024

Conversation

shubhanshukaintura
Copy link
Contributor

@shubhanshukaintura shubhanshukaintura commented May 11, 2024

PR Description πŸ“œ

The enhancement aims to improve the user experience of a web-based game by implementing keyboard event listeners for smooth music playback. Currently, users are required to interact with the mouse to trigger music playback, which can disrupt gameplay flow. By adding keyboard event listeners, users will be able to control music playback seamlessly using designated keyboard buttons, eliminating the need for mouse interaction. This enhancement enhances user convenience, contributes to a smoother gaming experience, and aligns with the goal of creating a more immersive gameplay environment.
Issue no. #3102


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) πŸ“Έ

Screenshot 2024-05-11 140140



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented May 11, 2024

Thank you @shubhanshukaintura ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunjgit kunjgit added level1 Documentation and small bug fixes in gssoc gssoc GSSoC24 program label labels May 12, 2024
@kunjgit kunjgit merged commit b84617d into kunjgit:main May 12, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @shubhanshukaintura , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

@shubhanshukaintura
Copy link
Contributor Author

Thank you @kunjgit , looking forward for many more valuable contributions πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants