Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the links to thumbnails in the game data json #3103

Merged
merged 1 commit into from May 12, 2024

Conversation

rahul-p19
Copy link
Contributor

@rahul-p19 rahul-p19 commented May 11, 2024

PR Description πŸ“œ

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #3091
Thumbnails for some games were not rendering. Fixed it by updating the url to the image in the game data json file.


Mark the task you have completed βœ…


Add your screenshots(Optional) πŸ“Έ

image
image



@kunjgit
Copy link
Owner

kunjgit commented May 11, 2024

Thank you @rahul-p19 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kunjgit kunjgit merged commit 2200336 into kunjgit:main May 12, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @rahul-p19 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

@kunjgit kunjgit added level1 Documentation and small bug fixes in gssoc gssoc GSSoC24 program label labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Thumbnails/Screenshots of games not visible on page 20
2 participants