Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e_node: DRA: test plugin failures #124617

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

e2e_node: DRA: test plugin failures #124617

wants to merge 8 commits into from

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Apr 29, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Test DRA plugin failures

Which issue(s) this PR fixes:

Fixes #124608

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2024
@bart0sh bart0sh mentioned this pull request Apr 29, 2024
Open
@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 29, 2024

/test all

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 29, 2024
@bart0sh bart0sh moved this from Triage to WIP in SIG Node PR Triage Apr 29, 2024
@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 29, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 29, 2024
@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 29, 2024

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2024
@bart0sh bart0sh force-pushed the PR144-e2e_node-DRA-test-plugin-failures branch from 897b635 to 1a840b9 Compare April 29, 2024 21:54
@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 29, 2024

/test all

@bart0sh bart0sh force-pushed the PR144-e2e_node-DRA-test-plugin-failures branch from 1a840b9 to 0df0457 Compare April 30, 2024 11:03
@bart0sh
Copy link
Contributor Author

bart0sh commented Apr 30, 2024

/test all

@bart0sh bart0sh mentioned this pull request Apr 30, 2024
Merged
@SergeyKanzhelev
Copy link
Member

/assign

@bart0sh bart0sh force-pushed the PR144-e2e_node-DRA-test-plugin-failures branch 2 times, most recently from 58e008c to 60321bb Compare May 3, 2024 21:28
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 3, 2024
@bart0sh
Copy link
Contributor Author

bart0sh commented May 3, 2024 •
edited

I'm done adding new test cases. They're all passing:

sudo _output/local/go/bin/e2e_node.test --ginkgo.focus="DRA" --ginkgo.v --report-dir=/tmp/e2e_node.test/logs --node-name=devel --kubelet-flags='--cluster-domain=cluster.local --fail-swap-on=false --cgroup-driver=systemd' --prepull-images=false --container-runtime-endpoint=unix:///run/containerd/containerd.sock --kubelet-config-file=test/e2e_node/jenkins/default-kubelet-config.yaml --runtime-config=api/all=true --service-feature-gates=DynamicResourceAllocation=true --feature-gates=DynamicResourceAllocation=true
...
Ran 16 of 583 Specs in 507.896 seconds
SUCCESS! -- 16 Passed | 0 Failed | 0 Pending | 567 Skipped
PASS

This PR is ready for review now. @pohly @klueska PTAL

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bart0sh
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bart0sh bart0sh marked this pull request as ready for review May 3, 2024 21:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from mtaufen and pohly May 3, 2024 21:30
@bart0sh bart0sh moved this from WIP to Needs Reviewer in SIG Node PR Triage May 3, 2024
@bart0sh
Copy link
Contributor Author

bart0sh commented May 3, 2024

2reviewers: This PR depends on #124323, so some tests may fail until #124323 is merged.

@bart0sh bart0sh force-pushed the PR144-e2e_node-DRA-test-plugin-failures branch from 60321bb to 2068c33 Compare May 3, 2024 21:59
@bart0sh
Copy link
Contributor Author

bart0sh commented May 4, 2024

/retest

@bart0sh bart0sh moved this from Triage to Issues - In progress in SIG Node CI/Test Board May 5, 2024
@bart0sh bart0sh force-pushed the PR144-e2e_node-DRA-test-plugin-failures branch from 2068c33 to ecaec49 Compare May 13, 2024 13:10
@bart0sh
Copy link
Contributor Author

bart0sh commented May 13, 2024

@klueska All new e2e_node test cases added by this PR pass with the code from #124323

@bart0sh
Copy link
Contributor Author

bart0sh commented May 13, 2024

/retest

@bart0sh
Copy link
Contributor Author

bart0sh commented May 14, 2024

/assign @pohly
/cc @kannon92

@bart0sh bart0sh moved this from Issues - In progress to PRs - Needs Reviewer in SIG Node CI/Test Board May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mtaufen mtaufen Awaiting requested review from mtaufen

@pohly pohly Awaiting requested review from pohly

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@pohly pohly

@SergeyKanzhelev SergeyKanzhelev

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
PRs - Needs Reviewer
SIG Node PR Triage
Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DRA: add e2e_node tests
5 participants
@bart0sh @k8s-ci-robot @SergeyKanzhelev @pohly @klueska