-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kubectl): delete pod declare no controllor note #120159
fix(kubectl): delete pod declare no controllor note #120159
Conversation
Hi @Ithrael. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The message looks like it is in good form. 👍🏼 |
/ok-to-test |
/retest |
May I ask what is the progress of this PR? @mpuckett159 @newtondev |
/triage accepted |
LGTM label has been added. Git tree hash: 1211e99e144972c8bb0c376354987a52968160be
|
Can this PR be merged? thx @mpuckett159 |
/triage accepted |
/help |
/release-note Change error message to more descriptive in kubectl drain command |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, Ithrael The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-none |
@ardaguclu: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Modify the error message of unmanagedFatal a more understandable prompt while keeping consistency with unmanagedWarning‘s grammar.
Which issue(s) this PR fixes:
Fixes # kubernetes/kubectl#1467
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: