Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix punctuation or reword the error message: "cannot delete Pods declare no controller" #1467

Closed
wvxvw opened this issue Aug 15, 2023 · 11 comments · Fixed by kubernetes/kubernetes#124597
Closed

Fix punctuation or reword the error message: "cannot delete Pods declare no controller" #1467

wvxvw opened this issue Aug 15, 2023 · 11 comments · Fixed by kubernetes/kubernetes#124597
Assignees
@Ithrael @itsajay1029 @vtrenton @TessaIO
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@wvxvw
Copy link

wvxvw commented Aug 15, 2023 

cannot delete Pods declare no controller

Is a... broken English? What were you trying to say here? Please make this error message make sense.

This is found in kubectl 1.25, but I'm not sure it's coming from kubectl itself, maybe it's from somewhere else. But due to the incomprehensible nature of this message I cannot even begin to guess where this may come from.

NB. The complete error message might look something like this:

error: unable to drain node "node005" due to error:cannot delete Pods declare no controller (use --force to override):

So, the formatting is also broken (missing space after colon).
@wvxvw wvxvw added the kind/bug Categorizes issue or PR as related to a bug. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 15, 2023
@Ithrael
Copy link
Contributor

Ithrael commented Aug 16, 2023 •
edited

When you drain a node, if there are direct pods on that node (meaning the pods have no owner, such as pods generated by a deployment which have owners), this error will occur.

return MakePodDeleteStatusWithError(unmanagedFatal)

image

@mpuckett159
Copy link
Contributor

/triage accept
/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

@mpuckett159: The label(s) triage/accept cannot be applied, because the repository doesn't have them.

In response to this:

/triage accept
/sig cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpuckett159
Copy link
Contributor

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@mpuckett159:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 16, 2023
@eshwarhs
Copy link

/assign

@Ithrael Ithrael removed their assignment Aug 17, 2023
@Ithrael
Copy link
Contributor

Ithrael commented Aug 17, 2023

/assign

@itsajay1029
Copy link

/assign

@itsajay1029 itsajay1029 mentioned this issue Aug 17, 2023
Closed
This was referenced Aug 17, 2023
Closed
Closed
@eshwarhs eshwarhs removed their assignment Aug 17, 2023
@Ithrael Ithrael mentioned this issue Aug 24, 2023
Merged
@brianpursley
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 13, 2023
@vtrenton
Copy link

vtrenton commented Dec 5, 2023

/assign

@vtrenton vtrenton mentioned this issue Dec 5, 2023
Closed
@Ithrael Ithrael mentioned this issue Jan 19, 2024
Closed
9 tasks
@TessaIO
Copy link
Contributor

TessaIO commented Apr 26, 2024

/assign

@TessaIO TessaIO mentioned this issue Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ithrael Ithrael

@itsajay1029 itsajay1029

@vtrenton vtrenton

@TessaIO TessaIO

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add whitespace to drain error message TessaIO/kubernetes
9 participants
@wvxvw @brianpursley @mpuckett159 @k8s-ci-robot @Ithrael @eshwarhs @itsajay1029 @vtrenton @TessaIO