Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cinder-csi-plugin] Enable optional storageclasses. #2578

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

powellchristoph
Copy link
Contributor

@powellchristoph powellchristoph commented Apr 19, 2024

[cinder-csi-plugin] Enable Optional StorageClasses

What this PR does / why we need it:
If you enable the included storageclasses, you get both the retain and delete. This PR allows each class to be enabled individually.

Which issue this PR fixes(if applicable):
na

Special notes for reviewers:
na

Release note:

[cinder-csi-plugin] Included storageclasses can be individually enabled.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 19, 2024
Copy link

linux-foundation-easycla bot commented Apr 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @powellchristoph. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
@dulek
Copy link
Contributor

dulek commented Apr 24, 2024

@powellchristoph: Before jumping into the code - you need to retain the release note box from the PR template: https://github.com/kubernetes/cloud-provider-openstack/blob/66624e34b1884781dca75f2ae6dc9736c0de9f28/.github/PULL_REQUEST_TEMPLATE.md

@dulek
Copy link
Contributor

dulek commented Apr 24, 2024

I'm looking into chart lint failure.

@dulek
Copy link
Contributor

dulek commented Apr 24, 2024

See #2582 for chart linting failure explanation. It's not fault of this patch, we'll fix it soon.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2024
@dulek
Copy link
Contributor

dulek commented Apr 24, 2024

Ah, looks like you need to make EasyCLA happy. Just click "Details" in its test table row and follow the steps.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 25, 2024
@powellchristoph
Copy link
Contributor Author

powellchristoph commented Apr 25, 2024

Ah, looks like you need to make EasyCLA happy. Just click "Details" in its test table row and follow the steps.

I've followed the link and filled it out twice now. Its sent me the email. I'm not sure what else I'm supposed to do. And I've previously commited :(

@dulek
Copy link
Contributor

dulek commented Apr 25, 2024

I'm not sure. We fixed the linting failure though.

@dulek
Copy link
Contributor

dulek commented Apr 25, 2024

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 25, 2024
@dulek
Copy link
Contributor

dulek commented Apr 26, 2024

/approve

Can you squash the commits before the final /lgtm?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants