[occm] add tag on floating ip create

[lidongshengxdayu]

What this PR does / why we need it:

In some scenarios, tags are used as resource tags, but occm creates a floating ip without a tag. This PR adds the same tag as the LB when the floating ip created.

Add tag same as LB for floating ip create

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: lidongshengxdayu (d28309f, 9180e6d, a7a5daf, 4319a88, 0e29ff2)

[k8s-ci-robot]

Welcome @lidongshengxdayu!

It looks like this is your first PR to kubernetes/cloud-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @lidongshengxdayu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fengyunpan2 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/openstack/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dulek]

I'm not really sure a failure to add a tag should be fatal and cause a full rollback. This most likely won't work either. I'd rather have the code follow K8s reconciling principles and make it fetch the FIP, check if tag exists and if not, add it. This would also handle the upgrade situations, so that after upgrade all FIPs without tags would get one.

[qinghon]

sure ，this is indeed not very clean. Now it is modified to check the tag when confirming the floating ip. If it does not exist, it will be added to the floating ip.

[dulek]

/ok-to-test

[dulek]

This looks like a sane request to be able to tag the FIPs created by CCM. This needs to handle one more case though:

loadbalancer.openstack.org/keep-floatingip annotation will force CCM to not delete the FIP. In such two cases we should untag the FIP.

While you're on this, be informed that a bunch of other folks are working on resource tagging, @stephenfin and @dd-georgiev.

[dulek]

This is still not untagging FIPs we don't delete properly.

[lidongshengxdayu]

This is still not untagging FIPs we don't delete properly.

it mean that you need to untag it when cancel the association?

[dulek]

See this comment for details: #2577 (comment)