Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-vip to v0.8.0 #11156

Merged
merged 7 commits into from May 21, 2024
Merged

Update kube-vip to v0.8.0 #11156

merged 7 commits into from May 21, 2024

Conversation

jisnardo
Copy link
Contributor

@jisnardo jisnardo commented May 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Keep kube-vip updated

Which issue(s) this PR fixes:

Fixes # version

Special notes for your reviewer:

Keep kube-vip updated

Does this PR introduce a user-facing change?:

Update kube-vip to v0.8.0

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 2, 2024
Copy link

linux-foundation-easycla bot commented May 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 2, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @jisnardo!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @jisnardo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@jisnardo jisnardo force-pushed the master branch 3 times, most recently from af5c84a to b1d9f1b Compare May 2, 2024 07:43
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 2, 2024
@mzaian
Copy link
Contributor

mzaian commented May 2, 2024

Hello @jisnardo

Thanks a lot for the PR. Did you check If you need to update the manifests Ref: https://github.com/kube-vip/kube-vip/blob/v0.8.0/pkg/kubevip/config_generator.go

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2024
@jisnardo
Copy link
Contributor Author

jisnardo commented May 2, 2024

Hi @mzaian, now yes Thanks.

@jisnardo
Copy link
Contributor Author

jisnardo commented May 2, 2024

/retest-required

@jisnardo
Copy link
Contributor Author

jisnardo commented May 3, 2024

/retest

1 similar comment
@jisnardo
Copy link
Contributor Author

jisnardo commented May 7, 2024

/retest

@jisnardo
Copy link
Contributor Author

jisnardo commented May 7, 2024

@mzaian what about this? packet_centos7-flannel-addons-ha https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/6783243276

@mzaian
Copy link
Contributor

mzaian commented May 7, 2024

@mzaian what about this? packet_centos7-flannel-addons-ha https://gitlab.com/kargo-ci/kubernetes-sigs-kubespray/-/jobs/6783243276

The error are visible here

TASK [kubernetes/node : Kube-vip | Write static pod] ***************************
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/kubernetes/node/tasks/loadbalancer/kube-vip.yml:9
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'kube_vip_svc_leasename' is undefined. 'kube_vip_svc_leasename' is undefined
fatal: [instance-1]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'kube_vip_svc_leasename' is undefined. 'kube_vip_svc_leasename' is undefined"}
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'kube_vip_svc_leasename' is undefined. 'kube_vip_svc_leasename' is undefined
fatal: [instance-2]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'kube_vip_svc_leasename' is undefined. 'kube_vip_svc_leasename' is undefined"}

@jisnardo
Copy link
Contributor Author

jisnardo commented May 8, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jisnardo: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jisnardo
Copy link
Contributor Author

jisnardo commented May 8, 2024

Now ready @mzaian, thanks

@mzaian
Copy link
Contributor

mzaian commented May 13, 2024

/cc @VannTen @yankay

@k8s-ci-robot k8s-ci-robot requested a review from yankay May 13, 2024 10:17
@yankay
Copy link
Member

yankay commented May 14, 2024

Thanks @mzaian
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@jisnardo
Copy link
Contributor Author

/retest-required

@VannTen
Copy link
Contributor

VannTen commented May 17, 2024

I'm not sure how we can override the status, because the CI is green, it's only the integration to gitlab which was broken due to token expiration and does not appear to be able to unstuck itself... 🤔

@VannTen
Copy link
Contributor

VannTen commented May 17, 2024

/override kubespray-ci/pipeline

@mzaian
Copy link
Contributor

mzaian commented May 19, 2024

@jisnardo Could you please rebase your branch.

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 20, 2024
@k8s-ci-robot
Copy link
Contributor

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jisnardo
Copy link
Contributor Author

@mzaian done.

@mzaian
Copy link
Contributor

mzaian commented May 20, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jisnardo, mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yankay yankay merged commit 7e0a407 into kubernetes-sigs:master May 21, 2024
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/contains-merge-commits kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants