New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix REAMDE in contrib/terraform/aws template #11130
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Brain2life The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Brain2life! |
Hi @Brain2life. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The documentation in contrib/terraform/aws is outdated and misleading in some places. The main issue is that it mentions
ubuntu
andcentos
usernames, while in fact we are usingadmin
user. I've lost some time to figure out why Ansible was not able to provision the cluster.I've updated the documentation and replaced the usernames to
admin
. Please review and update the documentation.Thank you!
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: