Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The contrasting statements and descriptions are inconsistent for kube version #11065

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Apr 8, 2024

The fail msg in https://github.com/kubernetes-sigs/kubespray/compare/master...my-git9:kubeversion?expand=1#diff-4da0e67b40b4f087f4528beccf9e990aa66cf96682581fce12a9801ff464b204L4:

msg: "Kubeadm version {{ kubeadm_version }} do not matches kubernetes {{ kube_version }}"

What should be compared here is the kube and kubeadm versions

What type of PR is this?

/kind bug

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

… kubeadm version

Signed-off-by: xin.li <xin.li@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2024
@yankay
Copy link
Member

yankay commented Apr 10, 2024

Thanks @my-git9

Because the code is from PR #6302.
@caruccio @floryut , would you please help to review it :-)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: my-git9, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@VannTen
Copy link
Contributor

VannTen commented May 16, 2024

Actually, this check does not really make sense:
We allow to customize kubeadm_version (it's defined in roles/kubespray-defaults/main/download.yml).

If we don't want to do that (which seems the intention of that check) we should just not allow the modification of kubeadm_version, by movings into vars/ instead, and get rid of the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants