Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Mesh version references in docs #3073

Merged
merged 1 commit into from May 13, 2024
Merged

Fixing Mesh version references in docs #3073

merged 1 commit into from May 13, 2024

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Follow up from #3066 (comment).

Does this PR introduce a user-facing change?:

NONE

/cc @howardjohn @keithmattix @kflynn

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 10, 2024
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LiorLieberman
Copy link
Member

/lgtm
/hold in case you wanted someone else to review as well

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@kflynn
Copy link
Contributor

kflynn commented May 13, 2024

Thanks @robscott!

/lgtm

@kflynn
Copy link
Contributor

kflynn commented May 13, 2024

Let's see if I can do this... 🙂

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 67e304b into kubernetes-sigs:main May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithmattix keithmattix keithmattix approved these changes

@howardjohn howardjohn Awaiting requested review from howardjohn

@kflynn kflynn Awaiting requested review from kflynn

Assignees

@kflynn kflynn

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@robscott @k8s-ci-robot @LiorLieberman @kflynn @keithmattix