Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement of GEP-995 #2985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

howardjohn
Copy link
Contributor

What type of PR is this?

/kind gep

What this PR does / why we need it:

Implements GEP-995

GEP: #2593 (merged)
Docs: #2946 (merged)

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Release note was in 2593

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn
Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me,
One nit: the GEP mentions

"This format for the name field of route rules differs from the pattern adopted for the SectionName type, which was thought for specifying mainly DNS subdomain names (RFC 1123), due to its use in the gateway listeners originally"

So although it is just a string, using v1.SectionName is a bit confusing. Maybe a dedicated type or simply a string?

@guicassolato
Copy link
Contributor

Generally looks good to me, One nit: the GEP mentions

"This format for the name field of route rules differs from the pattern adopted for the SectionName type, which was thought for specifying mainly DNS subdomain names (RFC 1123), due to its use in the gateway listeners originally"

So although it is just a string, using v1.SectionName is a bit confusing. Maybe a dedicated type or simply a string?

SectionName won't allow names such as my-rule123, my_rule, or myRule. https://go.dev/play/p/zRACGkGb_EG

Not sure what the best path is here, but I guess starting with SectionName is fine. Maybe it's the GEP that should change; then, if requested, another one opened to modify the definition of SectionName perhaps?

apis/v1/grpcroute_types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@shaneutt shaneutt removed their request for review May 9, 2024 14:53
@robscott
Copy link
Member

@guicassolato or @howardjohn I know this GEP is already essentially in scope for v1.2, but can one of you take a minute to leave a comment on #3103 so we make sure we're tracking it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants