Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gep-1762: Add attachTo to in cluster deployments GEP #2945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

howardjohn
Copy link
Contributor

What type of PR is this?
/kind gep

What this PR does / why we need it:

This is a followup to #1757. This was stripped out to get things into 1.0

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

A new `spec.infrastructure.attachTo` field has been added to `Gateway` to managed manually deployed infrastructure.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2024
@robscott
Copy link
Member

robscott commented Apr 5, 2024

This feels awfully similar to #1863 - it seems like we shouldn't try to tackle one of the problems (Gateway merging) without the other (Gateway Service attachment) given the significant overlap. Unfortunately I think we've run out of time in the v1.1 release cycle to fit something this big in, but I'd like to aim to get both concepts in as one of our first topics post v1.1 release.

@shaneutt shaneutt requested review from robscott and youngnick and removed request for shaneutt April 5, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants