Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly set default AZURE_SYNC_PERIOD for ASO #4764

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Apr 22, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

It looks like when we specify AZURE_SYNC_PERIOD: "" in the aso-controller-settings Secret, ASO is interpreting that as "do not resync" instead of "use the 1h default" like the docs describe and what we originally intended: https://azure.github.io/azure-service-operator/guide/aso-controller-settings-options/#azure_sync_period. This behavior might be a bug in ASO (Azure/azure-service-operator#3965), in which case this PR is a workaround. If this is intended behavior in ASO, then this PR represents a fix on our side.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

[`AZURE_SYNC_PERIOD`](https://azure.github.io/azure-service-operator/guide/aso-controller-settings-options/#azure_sync_period) for ASO now defaults to `1h` instead of "effectively never"

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.38%. Comparing base (3d9f761) to head (e720de6).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4764      +/-   ##
==========================================
- Coverage   62.47%   62.38%   -0.09%     
==========================================
  Files         195      196       +1     
  Lines       15902    16088     +186     
==========================================
+ Hits         9934    10037     +103     
- Misses       5268     5325      +57     
- Partials      700      726      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1bf9862dc5d36f7c55403a87c71824baf44409d4

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 753edfb into kubernetes-sigs:main Apr 22, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 22, 2024
@nojnhuh nojnhuh deleted the aso-resync-default branch April 23, 2024 21:02
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Apr 26, 2024

/cherry-pick release-1.13

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Apr 26, 2024

/cherry-pick release-1.14

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #4782

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #4783

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants