-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indention to forwardConfig #3522
base: main
Are you sure you want to change the base?
Conversation
This clarifies to the reader that `targetGroups` and `TargetGroupStickinessConfig` are both within the `forwardConfig`, which was not clear before due to lack of indentation.
|
Welcome @jacurtis! |
Hi @jacurtis. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM ✅ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacurtis, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jacurtis: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@AndrewCharlesHay, @jacurtis, can you please rebase the main branch to pick up the fix to e2e tests failure? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
This clarifies to the reader that
targetGroups
andTargetGroupStickinessConfig
are both within theforwardConfig
, which was not clear before due to lack of indentation.Issue
General improvement for docs readability, not related to an issue
Description
When configuring the
forwardConfig
, it was not initially clear to me that these two properties were part of theforwardConfig
block since they were indented to the same level as it, instead of indented a layer deeper to show nesting.This change simply provides the extra indention in the example code of the docs which should make it clearer to other readers to prevent them from making the same mistake.