Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add random string to e2e test role to avoid pipeline run conflicts #714

Merged

Conversation

bryantbiggs
Copy link
Member

What this PR does / why we need it:

  • Add random string to e2e test role to avoid pipeline run conflicts. When running multiple e2e tests concurrently across PRs, using the same role name means that the first process to finish will delete the role and the other processes will lose permission and fail, or the role will not be found for use

Reference: https://github.com/search?q=repo%3Akubernetes-sigs%2Faws-iam-authenticator%20aws-iam-authenticator-test-role-&type=code

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 26, 2024
@bryantbiggs
Copy link
Member Author

cc @wongma7 / @jaidevmane for the various test failures due to the IAM role not found - there is a conflict when multiple e2e tests are run concurrently across workflows since the same role name is used "globally"

@wongma7
Copy link
Contributor

wongma7 commented Apr 26, 2024

/lgtm
/approve

thank you.

it may be hardcoded to avoid roles leaking or something like that. But that is easy to solve in other ways i.e. sweeping them up with ttl.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit a81781b into kubernetes-sigs:master Apr 26, 2024
8 checks passed
@bryantbiggs bryantbiggs deleted the fix/unique-role-per-e2e branch April 26, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants