Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for e2e latency for dynamic mode and adoption rate metrics #690

Merged
merged 4 commits into from
Feb 28, 2024
Merged

add support for e2e latency for dynamic mode and adoption rate metrics #690

merged 4 commits into from
Feb 28, 2024

Conversation

minj131
Copy link
Contributor

@minj131 minj131 commented Jan 30, 2024

What this PR does / why we need it:

This adds logic to support e2e latency for dynamic mode and dynamic backend mode files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @minj131!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @minj131. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2024
@minj131 minj131 force-pushed the jaminmin/e2e-latency branch 3 times, most recently from 6575eda to 1ef4cd0 Compare January 30, 2024 21:11
@nnmin-aws
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2024
@minj131 minj131 force-pushed the jaminmin/e2e-latency branch 2 times, most recently from 8be18a5 to 4a8f577 Compare February 7, 2024 21:47
nnmin-aws
nnmin-aws reviewed Feb 19, 2024
View reviewed changes
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
@minj131 minj131 force-pushed the jaminmin/e2e-latency branch 5 times, most recently from 9c6ccfb to 6768da7 Compare February 19, 2024 18:05
@nnmin-aws
Copy link
Contributor

/re-test

@nnmin-aws
Copy link
Contributor

/retest

@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
jyotimahapatra
jyotimahapatra reviewed Feb 19, 2024
View reviewed changes
pkg/server/types.go Outdated Show resolved Hide resolved
@jyotimahapatra
Copy link
Contributor

/ok-to-test

jyotimahapatra
jyotimahapatra reviewed Feb 26, 2024
View reviewed changes
pkg/server/types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
nnmin-aws
nnmin-aws reviewed Feb 27, 2024
View reviewed changes
pkg/server/server.go Outdated Show resolved Hide resolved
jyotimahapatra
jyotimahapatra reviewed Feb 28, 2024
View reviewed changes
pkg/fileutil/util.go Outdated
@@ -104,3 +106,19 @@ func StartLoadDynamicFile(filename string, callBack FileChangeCallBack, stopCh <
}
}, time.Second, stopCh)
}

func CalculateTimeDeltaFromUnixInSeconds(from string, to int64) (float64, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are converting the data type from int64 to string and converting it back to int64 for comparison.
Please make it more focused by passing (string, int64) and only converting the first argument to int64.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the param names to startTime and endTime

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we drop the to parameter completely? The callers are passing time.Now anyway.

pkg/fileutil/util.go Outdated Show resolved Hide resolved
pkg/mapper/dynamicfile/dynamicfile.go
}

type DynamicFileData struct {
// Time that the object takes from update time to load time
LastUpdatedDateTime string `json:"LastUpdatedDateTime"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This being a string is going to cause problems in the future. We have to migrate this to the right representation(epoch time is always int64) in a future change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take an AI, this requires changes across all components unfortunately

pkg/server/types.go Show resolved Hide resolved
@minj131 minj131 force-pushed the jaminmin/e2e-latency branch 2 times, most recently from 09fe619 to 784221d Compare February 28, 2024 19:23
@minj131 minj131 force-pushed the jaminmin/e2e-latency branch 2 times, most recently from 42e7769 to 3099468 Compare February 28, 2024 20:03
jyotimahapatra
jyotimahapatra approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jyotimahapatra jyotimahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jyotimahapatra, minj131

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@nnmin-aws
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 098fdf3 into kubernetes-sigs:master Feb 28, 2024
8 checks passed
This was referenced Feb 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnmin-aws nnmin-aws nnmin-aws left review comments

@jyotimahapatra jyotimahapatra jyotimahapatra approved these changes

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@jyotimahapatra jyotimahapatra

@nnmin-aws nnmin-aws

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minj131 @k8s-ci-robot @nnmin-aws @jyotimahapatra