Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changelog for Training Operator v1.8.0-rc.0 #2104

Merged
merged 1 commit into from
May 31, 2024

Conversation

andreyvelich
Copy link
Member

I added changelog for Training Operator v1.8.0-rc.0.
Thanks everyone for your contribution to Training Operator 🎉

Also, I updated the changelog generation script.
We might need to update the release doc to follow similar process as for Katib: https://github.com/kubeflow/katib/tree/master/docs/release

/hold for review
/assign @kubeflow/wg-training-leads @deepanker13 @tariq-hasan @afritzler @champon1020 @shruti2522 @kellyaa @qzoscar @champon1020 @PeterWrighten @garymm @lowang-bh @double12gzh @rpemsel @franciscojavierarceo @jdcfd @shashank-iitbhu @daniel-hutao @kuizhiqing @testwill @Syulin7 @rpemsel @kubeflow/release-team

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@coveralls
Copy link

coveralls commented May 9, 2024

Pull Request Test Coverage Report for Build 9018741342

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 35.383%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 6 80.67%
Totals Coverage Status
Change from base Build 8997849275: -0.03%
Covered Lines: 4374
Relevant Lines: 12362

💛 - Coveralls

@andreyvelich
Copy link
Member Author

/hold cancel

@tenzen-y
Copy link
Member

/assign

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Basically, lgtm


### Release Process

1. Make sure the last commit you want to release past `kubeflow-training-operator-postsubmit` testing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed? IIUC, the prow doesn't exist, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point. I will fix this Readme in followup PR.

newTag: ${commit_hash}
```

> note: post submit job will always build a new image using the `PULL_BASE_HASH` as image tag.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> note: post submit job will always build a new image using the `PULL_BASE_HASH` as image tag.
> [!NOTE]
> Post submit job will always build a new image using the `PULL_BASE_HASH` as image tag.

Let's use the GitHub-style notification.
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f3792b0 into kubeflow:master May 31, 2024
38 checks passed
@andreyvelich andreyvelich deleted the changelog-1.8.0-rc.0 branch May 31, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants