-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changelog for Training Operator v1.8.0-rc.0 #2104
Add Changelog for Training Operator v1.8.0-rc.0 #2104
Conversation
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
628d46e
to
84b15df
Compare
Pull Request Test Coverage Report for Build 9018741342Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
/hold cancel |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Basically, lgtm
|
||
### Release Process | ||
|
||
1. Make sure the last commit you want to release past `kubeflow-training-operator-postsubmit` testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed? IIUC, the prow doesn't exist, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good point. I will fix this Readme in followup PR.
newTag: ${commit_hash} | ||
``` | ||
|
||
> note: post submit job will always build a new image using the `PULL_BASE_HASH` as image tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> note: post submit job will always build a new image using the `PULL_BASE_HASH` as image tag. | |
> [!NOTE] | |
> Post submit job will always build a new image using the `PULL_BASE_HASH` as image tag. |
Let's use the GitHub-style notification.
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I added changelog for Training Operator v1.8.0-rc.0.
Thanks everyone for your contribution to Training Operator 🎉
Also, I updated the changelog generation script.
We might need to update the release doc to follow similar process as for Katib: https://github.com/kubeflow/katib/tree/master/docs/release
/hold for review
/assign @kubeflow/wg-training-leads @deepanker13 @tariq-hasan @afritzler @champon1020 @shruti2522 @kellyaa @qzoscar @champon1020 @PeterWrighten @garymm @lowang-bh @double12gzh @rpemsel @franciscojavierarceo @jdcfd @shashank-iitbhu @daniel-hutao @kuizhiqing @testwill @Syulin7 @rpemsel @kubeflow/release-team