-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed import sort order on api_client.py using isort #2100
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Anindya Dey <anindyadey@Techs-Air-2.verizon.net>
Signed-off-by: Marc Maliar <marc.maliar77@gmail.com> Co-authored-by: Jocelyn Huang <jocelynYH4@gmail.com> Co-authored-by: Andreas Loutzidis <aloutzidis@gmail.com> Co-authored-by: Akshay Gupta <akshaygupta.us@gmail.com> Signed-off-by: Anindya Dey <anindyadey@Techs-Air-2.verizon.net>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anindyahepth The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 8945207080Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @anindyahepth 🎉
I left one comment.
from kubeflow.training.exceptions import ApiValueError, ApiException | ||
from kubeflow.training.configuration import Configuration | ||
from kubeflow.training.exceptions import ApiException, ApiValueError | ||
from six.moves.urllib.parse import quote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you remove changes from api_client.py file since this file is generated automatically by CODE_GEN: https://github.com/kubeflow/training-operator/blob/master/hack/python-sdk/gen-sdk.sh#L48.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: