Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Fix document.write with async script #481

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/write-stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,11 @@ export default class WriteStream {
_onScriptDone(tok) {
// Pop script and check nesting.
if (tok !== this.scriptStack[0]) {
if (this.deferredRemote === tok) {
// probably using document.write to output an async script with releaseAsync set to true
this.deferredRemote = null;
return;
}
this.options.error({msg: 'Bad script nesting or script finished twice'});
return;
}
Expand Down
17 changes: 16 additions & 1 deletion test/unit/tokenprocessing.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,5 +113,20 @@ describe('tokenprocessing', () => {
);
});

});
it('does something wierd.', done => {
const div = document.createElement('div');
div.id = 'document-write-async';
document.body.appendChild(div);
postscribe(div, '<script>document.write("<scr"+"ipt async src=\'remote/describe-write.js\'></scr"+"ipt>");</script>', {
releaseAsync: true,
done: () => {
expect(div.innerHTML).to.contain('<script async="" src="remote/describe-write.js"></script>');
done();
},
error: (error) => {
done(error);
}
});
});

});