Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taking in node resources in account #593

Closed
wants to merge 0 commits into from
Closed

Conversation

mudverma
Copy link
Collaborator

solving #513

@chaitanyaenr chaitanyaenr self-requested a review March 13, 2024 19:05
Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mudverma the changes are looking good. Can we rebase the PR and also add documentation on how we compare the threshold against node capacity if limits are not set please?

Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mudverma tried the PR on an application with no limits set: https://github.com/cloud-bulldozer/performance-dashboards/blob/master/dittybopper/README.md#deploy-grafana-on-openshift-cluster-with-dashboards with 0 thresholds set in the config and the results includes only memory and pvc scenarios instead of all:

"recommendations": {
    "mem_services_recommendations": {
        "services": [
            "dittybopper-65fdfb476c-snfff"
        ],
        "tests": [
            "node_memory_hog",
            "pvc_disk_fill"
        ]
    }
}

}

Thoughts?

Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitanyaenr
Copy link
Collaborator

@mudverma looks like there's a conflict, we might want to rebase with the latest changes. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants