Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intial translation of the figures for the chapters of hashing, tree, and graph #1339

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

krahets
Copy link
Owner

@krahets krahets commented May 4, 2024

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

@krahets krahets added translation English translation documents documents-related labels May 4, 2024
@krahets krahets self-assigned this May 4, 2024
@krahets
Copy link
Owner Author

krahets commented May 4, 2024

Please review the translation based on the following aspects:

  1. Ensure the expression is authentic and accurate.
  2. Maintain consistency between the Chinese and English versions. (Balancing with point 1)
  3. Since English is significantly longer than Chinese, some of the content has been simplified, resulting in poorer consistency. Please only add comments if you think it's ambiguous.

In addition to content, please pay attention to the format:

  1. It is expected to use Roboto font for normal text and Roboto Mono for formulas and code. These may be prone to mistakes since they are set manually.
  2. The style and color of shapes and texts should be consistent between the two versions. (I made some color adjustments in the EN version to enhance readability, so please only report those that feel uncomfortable to you.)

Copy link
Contributor

@K3v123 K3v123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the translations are accurate
its just the bold and colors again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word "address" has been left out on in.
maybe do "chained addresses"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chaining is enough, you can check it here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"capacity doubled" is not in bold unlike in CN it is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the node looks bold in CN but im not too sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bold was on 1st and 2nd but in en its on the "search" part

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no bold text or "complete binary tree"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same top is not bold. same as below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same not bold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not bold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same the bold for right rotation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right roatation is not in bold same goes for "rotate right" or is it just the style of text?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chaining is enough, you can check it here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Remove the element at the heap top” -> “Pop the top element from the heap.”

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Add the current element to the heap” -> "Push the current element into the heap."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documents documents-related translation English translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants