Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intial translation of the figures for the chapters of graph, searching, and sorting #1338

Open
wants to merge 1 commit into
base: base
Choose a base branch
from
Open

Add intial translation of the figures for the chapters of graph, searching, and sorting #1338

wants to merge 1 commit into from

Conversation

krahets
Copy link
Owner

@krahets krahets commented May 4, 2024

If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:

  • This PR represents the translation of a single, complete document, or contains only bug fixes.
  • The translation accurately conveys the original meaning and intent of the Chinese version. If deviations exist, I have provided explanatory comments to clarify the reasons.

If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:

  • I have thoroughly reviewed the code, focusing on its formatting, comments, indentation, and file headers.
  • I have confirmed that the code execution outputs are consistent with those produced by the reference code (Python or Java).
  • The code is designed to be compatible on standard operating systems, including Windows, macOS, and Ubuntu.

@krahets krahets added translation English translation documents documents-related labels May 4, 2024
@krahets krahets self-assigned this May 4, 2024
@krahets krahets changed the base branch from main to base May 4, 2024 11:15
@krahets krahets mentioned this pull request May 4, 2024
Merged
2 tasks
@krahets
Copy link
Owner Author

krahets commented May 4, 2024 •
edited

Please review the translation based on the following aspects:

  1. Ensure the expression is authentic and accurate.
  2. Maintain consistency between the Chinese and English versions. (Balancing with point 1)
  3. Since English is significantly longer than Chinese, some of the content has been simplified, resulting in poorer consistency. Please only add comments if you think it's ambiguous.

In addition to content, please pay attention to the format:

  1. It is expected to use Roboto font for normal text and Roboto Mono for formulas and code. These may be prone to mistakes since they are set manually.
  2. The style and color of shapes and texts should be consistent between the two versions. (I made some color adjustments in the EN version to enhance readability, so please only report those that feel uncomfortable to you.)

K3v123
K3v123 reviewed May 5, 2024
View reviewed changes
Copy link
Contributor

@K3v123 K3v123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me.
just some bolds text again in EN ver

en/docs/chapter_graph/graph_operations.assets/adjacency_list_step2_add_edge.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text are not bold in en ver. same for below

en/docs/chapter_sorting/counting_sort.assets/counting_sort_step7.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eng ver not bold

en/docs/chapter_sorting/merge_sort.assets/merge_sort_step1.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not bold, same as below images

en/docs/chapter_sorting/selection_sort.assets/selection_sort_step1.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "1st" is bold in CN same as the "5th" in below and other images etc

RafaelCaso
RafaelCaso approved these changes May 16, 2024
View reviewed changes
Copy link

@RafaelCaso RafaelCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (no typos)
My only input is in bubble_sort_overview.png and selection_sort_step11.png we say,
"remaining one element"

I understand we're saying, the element that has a value of 1, correct? It might be a little confusing. Maybe use quotation marks around one (remaining "one" element) but I think that looks a little silly. Maybe format it so it sticks out more? I'd be curious what other reviewers think of this.

RafaelCaso
RafaelCaso reviewed May 16, 2024
View reviewed changes
en/docs/chapter_sorting/bubble_sort.assets/bubble_sort_overview.png
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"remaining one element..." seems a little confusing. Curious what others think about this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(remaining one element does not need sorting) -> (no need to sort the remaining element)

RafaelCaso
RafaelCaso reviewed May 16, 2024
View reviewed changes
en/docs/chapter_sorting/selection_sort.assets/selection_sort_step11.png
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"remaining one element..." seems a little confusing. Curious what others think about this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(remaining one element does not need sorting) -> (no need to sort the remaining element)

pengchzn
pengchzn reviewed May 21, 2024
View reviewed changes
en/docs/chapter_sorting/summary.assets/sorting_algorithms_comparison.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leftmost column is missing.

en/docs/chapter_sorting/selection_sort.assets/selection_sort_step11.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(remaining one element does not need sorting) -> (no need to sort the remaining element)

en/docs/chapter_sorting/insertion_sort.assets/insertion_operation.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily store base

en/docs/chapter_sorting/heap_sort.assets/heap_sort_step1.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of these two pics seem different

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Insert data into the heap” may be better, the same goes for the following

en/docs/chapter_sorting/heap_sort.assets/heap_sort_step10.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack the translation of "Valid interval"

en/docs/chapter_sorting/heap_sort.assets/heap_sort_step12.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shaded area is incorrect.

en/docs/chapter_sorting/bubble_sort.assets/bubble_sort_overview.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(remaining one element does not need sorting) -> (no need to sort the remaining element)

en/docs/chapter_searching/replace_linear_by_hashing.assets/two_sum_brute_force.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when a combination with the sum equal to target.

en/docs/chapter_searching/binary_search_insertion.assets/binary_search_insertion_naive.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use binary search to find any 6
use linear search to find...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengchzn pengchzn pengchzn left review comments

@RafaelCaso RafaelCaso RafaelCaso approved these changes

@K3v123 K3v123 K3v123 left review comments

Assignees

@krahets krahets

Labels
documents documents-related translation English translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krahets @pengchzn @RafaelCaso @K3v123