Add API methods for forum group topics #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
requested changes
May 25, 2023
| fun createForumTopic( | ||
| chatId: ChatId, | ||
| name: String, | ||
| iconColor: Int? = null, |
There was a problem hiding this comment.
As far as it must be one of a limited list of values, what do you think about using an enum for it?
It would be easier to use and will avoid issues
| private val callbackAnswerText: String? = null, | ||
| private val callbackAnswerShowAlert: Boolean? = null, | ||
| private val callbackAnswerUrl: String? = null, | ||
| private val callbackAnswerCacheTime: Int? = null, | ||
| private val handleCallbackQuery: HandleCallbackQuery | ||
| ) : Handler { | ||
|
|
||
| private val callbackDataRegex = callbackData?.let { Regex(Regex.escape(it) + "\\b.*") } |
There was a problem hiding this comment.
Is it related to this PR?
| @@ -54,11 +59,11 @@ sourceSets { | |||
| } | |||
|
|
|||
| compileKotlin { | |||
| kotlinOptions.jvmTarget = "1.8" | |||
| kotlinOptions.jvmTarget = "17" | |||
There was a problem hiding this comment.
Do we need to update jvmTarget?
This change could be a breaking change for the users that are using this library.
jvmTarget 17 is not supported by Android SDK yet, so whatever person using it on an Android Application could have some issues adding the library
| @@ -5,7 +5,7 @@ buildscript { | |||
| } | |||
|
|
|||
| plugins { | |||
| id "org.jetbrains.kotlin.jvm" version "1.5.31" | |||
| id "org.jetbrains.kotlin.jvm" version "1.8.10" | |||
There was a problem hiding this comment.
Could we have this change on a different PR?
| @@ -3,7 +3,7 @@ package com.github.kotlintelegrambot | |||
| import com.github.kotlintelegrambot.entities.Update | |||
| import com.google.gson.Gson | |||
|
|
|||
| internal class UpdateMapper(private val gson: Gson) { | |||
| class UpdateMapper(private val gson: Gson) { | |||
There was a problem hiding this comment.
Do we need to open access to this class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following methods: