Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for IDE-level C# editing #109

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for IDE-level C# editing #109

wants to merge 5 commits into from

Conversation

cg505
Copy link
Contributor

@cg505 cg505 commented Jul 7, 2018

I'm going to let this sit for a couple of days while I use it and try to find any remaining bugs. Feel free to review in the meantime, however.

@cg505 cg505 requested review from rye and samontea July 7, 2018 17:23
@cg505
Copy link
Contributor Author

cg505 commented Jul 7, 2018

Also, ideally, tests (as coveralls has noted).

rye
rye previously requested changes Jul 7, 2018
View reviewed changes
Copy link
Member

@rye rye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits.

.emacs.d/bin/omnisharp Show resolved Hide resolved
.emacs.d/bin/omnisharp Outdated Show resolved Hide resolved
.emacs.d/lisp/code/languages/csharp.el Outdated Show resolved Hide resolved
.emacs.d/lisp/code/languages/csharp.el Show resolved Hide resolved
.emacs.d/lisp/code/languages/csharp.el Outdated Show resolved Hide resolved
.emacs.d/lisp/code/smartparens-c.el Outdated Show resolved Hide resolved
@rye rye changed the title add support for IDE-level C# editing Add support for IDE-level C# editing Jul 7, 2018
@cg505 cg505 dismissed rye’s stale review July 7, 2018 17:49

comments addressed

@cg505 cg505 requested a review from rye July 7, 2018 17:50
rye
rye approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@rye rye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits resolved, I say this is ship ready.

@cg505
Copy link
Contributor Author

cg505 commented Jul 7, 2018

Nice. I'm going to use it at work on Monday/Tuesday and see how it's holding up, then merge.

@rye rye added the Shipping Hold Should not be shipped until the shipping hold has been cleared. label Jul 7, 2018
@cg505
Copy link
Contributor Author

cg505 commented Jul 18, 2018

Can anyone jog my memory on how we are supposed to deal with tabs?

@rye
Copy link
Member

rye commented Jul 18, 2018

Smart-tabs by default, if I recall correctly.

@cg505
Copy link
Contributor Author

cg505 commented Jul 18, 2018

Okay, I will look into that. Also, I was looking at kotct/setf-tab, which I think needs a revamp. Fodder for another issue.

@cg505
Copy link
Contributor Author

cg505 commented Jul 18, 2018

We don't really need to mess with kotct/setf-tab in this case anyway, since csharp-mode (being a C-derived language mode) uses c-basic-offset.

@cg505
Copy link
Contributor Author

cg505 commented Jun 28, 2019

coming up on a year long of "a couple days" lol

rye
rye requested changes May 30, 2020
View reviewed changes
Copy link
Member

@rye rye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs merge conflicts resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rye rye rye requested changes

@samontea samontea Awaiting requested review from samontea

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Shipping Hold Should not be shipped until the shipping hold has been cleared. Type: Implementation of Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cg505 @rye