Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2.53, redesign the build system. #39

Closed
wants to merge 14 commits into from

Conversation

ezdiy
Copy link
Member

@ezdiy ezdiy commented Sep 30, 2020

The way this is currently used is a lovecraftian fever of unmaintainable nightmare. Let's try to tackle this cthulthu:

  • k2pdfopt is left in pristine for as much as possible, so that we get drag&drop code updates for future versions. For now the small patches for android etc will be done by koreader-base, but it may devolve into a tracking fork again if our changes to k2pdfopt will ever become actually invasive.
  • Keep our makefile strictly utilitarian to just build the library and nothing else
  • mupdf, tess and leptonica are now built in base, we get em via CFLAGS/LDFLAGS.
  • patches to mupdf, tess and leptonica are explicitly pre-built via heuristic in make_patches.sh. Those are then applied during build in Bump mupdf, kopt, lept and tess koreader-base#1203 this may seem needlessly complicated, but it helps to keep things transparent what those patches are actually about compared to that horrible file-replacement thing. It also scales to bumping versions of those libraries (to an extent).

todo: Darwin build.


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Sep 30, 2020

Which parts of the diff/result should I look at? Basically just the Makefile?

@ezdiy
Copy link
Member Author

ezdiy commented Sep 30, 2020

Ye, i should probably split it into one doing the flat replace and second with my changes to port to new APIs.

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks like good concepts to me. 👍

@ezdiy ezdiy marked this pull request as draft October 3, 2020 23:07
@ezdiy ezdiy changed the title RFC: Update to 2.53, redesign the build system. Update to 2.53, redesign the build system. Oct 4, 2020
@NiLuJe
Copy link
Member

NiLuJe commented Oct 4, 2020

What he said ;).

(I've just realized that I wasn't watching this repo ^^).

@ezdiy
Copy link
Member Author

ezdiy commented Oct 4, 2020

Hmm, people are looking, better squash the bloat inbetween so they don't judge :>

@Frenzie
Copy link
Member

Frenzie commented May 31, 2024

Superseded by #49. Thanks for all the effort @ezdiy :-)

@Frenzie Frenzie closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants