Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(site): Add guideline for localization #3776

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lupusA
Copy link
Contributor

@lupusA lupusA commented Apr 4, 2024

Hi,

this PR adds the ability to support localisation in kopia-UI. The PR contains the following changes:

  1. Adds a guidline to outline the localisation process

This PR has a dependency to kopia/htmlui#241

Feedback is welcomed.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.96%. Comparing base (cb455c6) to head (37dffde).
Report is 92 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3776      +/-   ##
==========================================
+ Coverage   75.86%   76.96%   +1.09%     
==========================================
  Files         470      476       +6     
  Lines       37301    29039    -8262     
==========================================
- Hits        28299    22349    -5950     
+ Misses       7071     4749    -2322     
- Partials     1931     1941      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julio-lopez julio-lopez changed the title docs(site): Add guidline for localisation docs(site): Add guideline for localization Apr 4, 2024
@@ -10,13 +10,15 @@ weight: 50
## Localisation Guidlines
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Localisation Guidlines
## Localisation Guidelines

TBD

### Tests
```kopiaUI``` features different tests to prevent situations where translations become obsolet and or unused. The tests check for keys with empty or null values and that keys exist in all provided translation files. The tests will fail if translation files contain empty keys or if keys are not declared in all files. Additionally, the test extracts the currently used translation keys within the code to check if all keys are used at least once.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```kopiaUI``` features different tests to prevent situations where translations become obsolet and or unused. The tests check for keys with empty or null values and that keys exist in all provided translation files. The tests will fail if translation files contain empty keys or if keys are not declared in all files. Additionally, the test extracts the currently used translation keys within the code to check if all keys are used at least once.
```kopiaUI``` features different tests to prevent situations where translations become obsolete and or unused. The tests check for keys with empty or null values and that keys exist in all provided translation files. The tests will fail if translation files contain empty keys or if keys are not declared in all files. Additionally, the test extracts the currently used translation keys within the code to check if all keys are used at least once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants