Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: coscheduling plugin sync scheduled in controller #2032

Merged
merged 1 commit into from
May 21, 2024

Conversation

xulinfei1996
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

#2030

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 68.75%. Comparing base (038308b) to head (0e3518c).
Report is 6 commits behind head on main.

Files Patch % Lines
...eduler/plugins/coscheduling/controller/podgroup.go 76.47% 3 Missing and 1 partial ⚠️
pkg/scheduler/plugins/coscheduling/core/core.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
- Coverage   68.76%   68.75%   -0.02%     
==========================================
  Files         423      423              
  Lines       39199    39181      -18     
==========================================
- Hits        26956    26938      -18     
- Misses       9910     9916       +6     
+ Partials     2333     2327       -6     
Flag Coverage Δ
unittests 68.75% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xulinfei1996 xulinfei1996 force-pushed the fix-gang-status branch 4 times, most recently from dc4f68b to df0998d Compare May 8, 2024 02:49
@hormes
Copy link
Member

hormes commented May 8, 2024

Please add a test in #2030,which should be able to run after this fix.

Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
@hormes
Copy link
Member

hormes commented May 8, 2024

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants