Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --install-tab-completion option for installing shell completion #648

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

amalthundiyil
Copy link
Contributor

@amalthundiyil amalthundiyil commented Jun 9, 2022

Description

The user gets four options to choose from bash, zsh, fish and auto (auto-detects shell using shellingham). To activate shell completion run:

kart config --install-completion auto

Replace auto with desired shell eg:

kart config --install-completion zsh

Completion will take effect once you restart the terminal

Related links:

Checklist:

  • Have you reviewed your own change?
  • Have you included test(s)?
  • Have you updated the changelog?

@amalthundiyil amalthundiyil changed the title Support tab completion on build Add --install-completion option for installing shell completion Jun 13, 2022
@amalthundiyil amalthundiyil force-pushed the tab-build branch 14 times, most recently from fe723a9 to f80f957 Compare June 14, 2022 06:15
@amalthundiyil amalthundiyil marked this pull request as ready for review June 14, 2022 06:46
Copy link
Collaborator

@olsen232 olsen232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Here's my comments, nothing major

kart/cli.py Outdated Show resolved Hide resolved
kart/cli.py Outdated Show resolved Hide resolved
kart/cli.py Outdated Show resolved Hide resolved
kart/completion.py Show resolved Hide resolved
kart/completion.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@amalthundiyil amalthundiyil changed the title Add --install-completion option for installing shell completion Add --install-tab-completion option for installing shell completion Jun 16, 2022
`shellingham` is made use of in shell completion. The license they use
is the ISC License [1].

[1] https://github.com/sarugaku/shellingham/blob/23cb5cbacaf86fd9e32368b1531e281607b32d13/LICENSE
The user gets four options to choose from bash, zsh, fish and
auto (auto detects shell using `shellingham`). To activate
shell completion run:

        kart config --install-completion auto

Replace `auto` with desired shell eg:

        kart config --install-completion zsh

Completion will take effect once you restart the terminal.
@craigds craigds merged commit 97ef458 into koordinates:master Jul 4, 2022
@amalthundiyil amalthundiyil deleted the tab-build branch July 4, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants