New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stopwords 기능 구현 #310
Open
hexists
wants to merge
15
commits into
konlpy:master
Choose a base branch
from
hexists:stopwords
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
stopwords 기능 구현 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
유용한 contribution 감사합니다. 위의 질문에 대한 제 의견을 적습니다.
|
@sunglok 의견 감사합니다.
궁금한 점이 있습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요.
#184 이슈를 보고, konlpy를 위한 stopwords 기능을 구현했습니다.
stopwords 구현을 위해, 여러 경로에서 stopwords를 수집했습니다.
아래 파일들을 이용해서 stopwords.word.txt와 stopwords.morph.txt 파일을 생성했습니다.
(stopwords.word.txt, stopwords.morph.txt를 생성하는 프로그램은 별도의 repo에 정리했습니다.)
CONTRIBUTING에 따라 PR 보내기 전 과정을 수행했습니다.
make check, make testall
과정 중 오류가 있었지만, 본 기능과 관련이 없어 보여 PR 보냅니다.(관련 오류는 #309 에 이슈로 등록했습니다.)
사용 방법입니다.
형태소 단위와 단어 단위에 대한 stopwords를 제공합니다.
함수의 사용법은 nltk와 유사하게 개발했습니다.
PR을 보내면서 몇가지 질문이 있습니다.
그렇다면, 어떤 경로에 추가되는 것이 좋을지 의견 부탁드립니다.
신규 기능에 대한 검토 부탁드립니다.