Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew no auto update to brew execs #1713

Merged
merged 5 commits into from May 13, 2024
Merged

Conversation

Micah-Kolide
Copy link
Contributor

Multiple homebrew commands will invoke brew update before running the command that's called. This can cause unpredictable data being returned. Adding HOMEBREW_NO_AUTO_UPDATE=1 to the exec will ensure this doesn't happen.

@Micah-Kolide
Copy link
Contributor Author

Micah-Kolide commented May 11, 2024

Of course it was just simply setting BOTH pwd and home, not only one of them, which I would've had figured out two days ago if I just tested that as well instead of thinking that wasn't the issue since setting one or the other didn't work...

I figure there wouldn't really be a case where we want to keep root's context of PWD and HOME over the running user's, so that's why I decided to throw it in the run_as_user exec option instead of making something specific for brew.

@Micah-Kolide
Copy link
Contributor Author

Brew should be fully fixed with this pr... hopefully.

Copy link
Contributor

@RebeccaMahany RebeccaMahany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Micah-Kolide Micah-Kolide added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit ae62a30 May 13, 2024
31 checks passed
@Micah-Kolide Micah-Kolide deleted the micah/make_brew_no_update branch May 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants