Allow named arguments anywhere #491
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWhiting
force-pushed
the
named-anywhere
branch
from
d80a601
to
b76d3aa
Compare
TimWhiting
force-pushed
the
named-anywhere
branch
2 times, most recently
from
c614214
to
593bb1a
Compare
TimWhiting
commented
Apr 10, 2024
test/syntax/run/tail.kk.out
Outdated
There was a problem hiding this comment.
There seems to be a bug (that is currently also on dev, where implicit resolution considers but doesn't accept functions which would match using a default for an optional parameters).
TimWhiting
commented
May 3, 2024
| = do let (nfixed,rest) = span (isNothing . fst) nargs | ||
| (nnamed,morefixed) = span (not . isNothing . fst) rest | ||
| = do let nfixed = filter (isNothing . fst) nargs | ||
| nnamed = filter (not . isNothing . fst) nargs | ||
| fixed = map snd nfixed |
There was a problem hiding this comment.
Instead of using span, we just filter by whether they have a name.
TimWhiting
commented
May 3, 2024
| fixed = map snd nfixed | ||
| named = [((name,rng),expr) | (Just (name,rng),expr) <- nnamed] | ||
| -- check that named arguments all come after the positional ones | ||
| case morefixed of | ||
| [] -> return () | ||
| (arg:_) -> infError (getRange (snd arg)) (text "positional arguments cannot follow named arguments") |
There was a problem hiding this comment.
No error is needed any more!
TimWhiting
commented
May 3, 2024
| @@ -138,10 +138,11 @@ matchArguments matchSome range free tp fixed named mbExpResTp | |||
| then unifyError NoMatch | |||
| else do -- trace (" matchArguments: " ++ show (map pretty pars, map pretty fixed, map pretty named)) $ return () | |||
| -- subsume fixed parameters | |||
| let (fpars,npars) = splitAt (length fixed) pars | |||
| let parsNotNamedArg = filter (\(nm,tp) -> nm `notElem` map fst named) pars | |||
| let (fpars,rest) = splitAt (length fixed) parsNotNamedArg | |||
There was a problem hiding this comment.
The only other change really is during unification removing all the supplied named arguments from parameters before determining which ones are fixed.
There was a problem hiding this comment.
Other than two more one line changes just below this, all of the rest of the changes are in updating tests.
This was referenced May 22, 2024
TimWhiting
force-pushed
the
named-anywhere
branch
from
593bb1a
to
737a1c9
Compare
TimWhiting
force-pushed
the
named-anywhere
branch
from
737a1c9
to
7ce5203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this feature is to allow trailing lambdas to come after named arguments. I've run into this a lot.
(Currently an error).
Essentially, instead of thinking of formal parameters as named or fixed, we consider them required or optional, with implicit parameters being required parameters, but optional as arguments.
Arguments are still thought of as named or fixed.
Subsumption proceeds as follows:
After matching the named arguments to formal parameters, the fixed arguments must match the ordering of the remaining parameters, with optional parameters staying optional.
In making these changes I noticed that the
syntax/runtest subdirectory was not actually being run, since it inherited a-lflag from thesyntaxdirectory. I moved those tests into asyntax/no-runsubdirectory to prevent the conflicting flags.Alternatively we could adjust the trailing lambda desugaring to put it prior to all named arguments. See PR #533
The main advantage of this particular solution is that it also allows for function "configuration" to happen prior to giving common arguments that would cause more indentation and visual clutter / noise if named.
Could be written like this, but becomes noisy and causes deeper indentation (depends how you format it)