Add support for websocket connection cancellation via Shutdown() method #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttjiaa
force-pushed
the
add-cancellation
branch
2 times, most recently
from
1a532b7
to
10ab726
Compare
ttjiaa
changed the title
seriousben
reviewed
Jul 25, 2018
websocketproxy_test.go
Outdated
| @@ -121,4 +122,6 @@ func TestProxy(t *testing.T) { | |||
| if msg != string(p) { | |||
| t.Errorf("expecting: %s, got: %s", msg, string(p)) | |||
| } | |||
|
|
|||
| proxy.Shutdown(context.Background()) | |||
There was a problem hiding this comment.
Would it be useful to test the going away close message?
seriousben
approved these changes
Jul 26, 2018
moorara
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for closing of proxied websocket connections via a
Shutdown(ctx context.Context) errormethod.This is useful in the case where the service handling the proxied connections is shutting down, and we want to gracefully disconnect the websocket connections.