Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting cookie domain on a per-request basis. #227

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rahulgi
Copy link

@rahulgi rahulgi commented Apr 23, 2024

This is a proof-of-concept to enable passing a function for the domain config option to dynamically modify the cookie domain based on the incoming request.

It does so by adding a call to a new modifyOptsForRequest helper anywhere cookies.set is called.

modifyOptsForRequest creates a copy of opts, checks whether the opts.domain value is a function, and replaces the domain value with the result of that function if so.

An example of how this might be used:

app.use(session({
  domain: (ctx, opts) => {
    return ctx.get("origin") || DEFAULT_ORIGIN;
  }
});

This specifically addresses #188, but it should be easy to extend this PR to support the other cookie config options (like httpOnly, maxAge, etc.). If this approach looks good and maintainers would be interested in the fix, I'd be happy to update this PR to properly do so - let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant