Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send RSET command on connection return #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreyra01
Copy link

@andreyra01 andreyra01 commented Mar 21, 2023

I've been getting an error 503 5.5.1 Error: nested MAIL command once in a while. Couldn't reproduce the issue in local enviroment but i suspect that connections somehow are returned to pool in unfinished state and then used for sending next message resulting in multiple MAIL commands. Resetting connection when returning to pool solved the issue.

@knadh
Copy link
Owner

knadh commented Mar 22, 2023

Ah, in fact the last commit 844bd4a specifically had fixed the nested mail issue. Bad connections were incorrectly being reused. Maybe the correct approach was to issue a reset there?

While this patch ensures that a connection is cleaned every time, I'm not sure if that's the ideal way. Connections shouldn't be in undetectable bad states in the first place. Would be great if that could be figured out first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants