Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi task create #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

colingm
Copy link

@colingm colingm commented Aug 11, 2018

Pull request to support batch creation of tasks and notes using :: as a delimiter. Addresses #22 but couldn't use | as delimiter without forcing the creator to wrap the whole description in quotations. If a better delimiter is suggested and agreed upon I can quickly switch it out.

Creating multiple notes

image

Creating multiple tasks with priority

image

Creating single task

image

@dougmaitelli
Copy link

I like the idea of supporting multi task create, but I personally don't like de abc::xyz syntax and can't think of any other delimiter which would be better.
Probably the ideal would be something like:

tb @board -t Task 1 -t Task 2

But it would require a bigger rewrite to avoid repeating the board, and would also require descriptions to be in quotes.

@@ -111,13 +110,13 @@ class Taskbook {
}
});

const description = desc.join(' ');
const descriptions = desc.join(' ').split('::');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add this as a constant or even an option somewhere to be changed easily.

@DLvalentine
Copy link

I'm not sure that continuing to use flags would be a good choice either. I think the usage of a delimiter is a good idea, and perhaps something that could be configurable to a user's preference. I would use semi-colons, personally. But making a user have to use more flags degrades the experience.

Good work on this, though. Batch creation is an awesome addition.

@ManuelTS
Copy link

@dougmaitelli What speaks against a default delimiter, and the user can set it to this needs? The delimiter char can be stored in the storage.jsonor in an seperate config.json file.

@dougmaitelli
Copy link

@ManuelTS I just think it looks clearer and more user friendly to split the tasks in batch creation using flags or something else that don't append everything in a long string. But if the delimiter is customizable that could also be enough I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants