Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to customize grey text #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duynguyenhoang
Copy link

@duynguyenhoang duynguyenhoang commented Aug 2, 2018

Result: Before and After by using magentaBright
Before - After by using magentaBright

@duynguyenhoang duynguyenhoang force-pushed the add_config_to_grey_text_render branch 2 times, most recently from 92dffae to 92a0408 Compare August 6, 2018 09:27
@klaudiosinani klaudiosinani self-requested a review August 7, 2018 16:16
@klaudiosinani klaudiosinani added the enhancement New feature or request label Aug 7, 2018
@kalexmills
Copy link

I foresee later requests for config of the other colors as well. 🔮

@marianocordoba
Copy link

I need this! Just removed Taskbook because that gray text is almost invisible in my terminal.

@thornjad
Copy link

For a hacky dirty fix before this PR is accepted, you can manually edit lib/render.js, and change line 9 from

const {blue, green, grey, magenta, red, underline, yellow} = chalk;

to

const {blue, green, magenta, red, underline, yellow} = chalk;
const grey = chalk.whiteBright; // or whatever color you want

@deekej
Copy link

deekej commented Apr 5, 2019

When can we expect this to be reviewed/fixed and merged? I really need this as well, since I'm using grey background in my terminal... :-/

@breuerfelix
Copy link

breuerfelix commented Nov 5, 2019

still need this fix to be merged...

guess alot of users got a dark terminal theme :)

/edit

@thornjad you also have to change const to let otherwise it wont let your redefine the var :)

@thornjad
Copy link

thornjad commented Nov 6, 2019

@breuerfelix you can certainly use let if you'd like to redefine it! I prefer to use const whenever possible.

@breuerfelix

This comment has been minimized.

@thornjad
Copy link

thornjad commented Nov 7, 2019

@breuerfelix oh no problem, I should have realized that was our disconnect! I was a bit distracted yesterday.

@deekej
Copy link

deekej commented Apr 21, 2020

Sadly, seems like this project has become dead... :-/

@klaudiosinani
Copy link
Owner

klaudiosinani commented Apr 24, 2020

All PRs and issues will be addressed shortly.
The development of Taskbook has not been terminated and will never be.

@fbrinker
Copy link

fbrinker commented Jul 7, 2020

Any news on this? :)
Would be awesome to have that feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants