Sort versions #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaaspieter
force-pushed
the
sort-versions
branch
18 times, most recently
from
126dcf7
to
01ac3e9
Compare
Some tests were failing because our sort order was depending on the order `mdfind` was returning Xcodes. This uses sort -n to sort versions by their numeric order.
klaaspieter
force-pushed
the
sort-versions
branch
10 times, most recently
from
6bc5258
to
69a9f31
Compare
klaaspieter
force-pushed
the
sort-versions
branch
12 times, most recently
from
003af47
to
7bdcee9
Compare
klaaspieter
force-pushed
the
sort-versions
branch
from
7bdcee9
to
27d458d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were failing because our sort order was depending on the
order
mdfindwas returning Xcodes. This uses sort -n to sort versionsby their numeric order.