Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Quick POC for #2823 #2920

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: Quick POC for #2823 #2920

wants to merge 2 commits into from

Conversation

atodorov
Copy link
Member

@atodorov atodorov commented Sep 21, 2022

Upstream todo:

  • Enable testing with GitHub Actions in django-tabular-permissions
  • Add tests for their Demo app, make sure that it works with latest Django
  • Fix anything that needs fixing

Then:

  • Extend django-tabular-permissions to display additional text from apps/models. For AppConfig we can use doc-string or custom attribute. For models we can only use doc-string b/c it seems custom attributes on the Meta class aren't suported! Nor is a Meta doc-string!

Then:

  • Update to the appropriate django-tabular-permissions version and
  • Document each app & model

Also TODO:

  • Some models aren't needed, filter them out of the query set
  • Do the same for TenantGroup model

atodorov and others added 2 commits September 21, 2022 17:28
Upstream todo:

- enable testing with GitHub Actions in django-tabular-permissions
- Add tests for their Demo app, make sure that it works with latest
  Django
- Fix anything that needs fixing

Then:

- Extend django-tabular-permissions to display additional text from
  apps/models. For AppConfig we can use doc-string or custom attribute.
  For models we can only use doc-string b/c it seems custom attributes
  on the Meta class aren't suported! Nor is a Meta doc-string!

Then:

- Update to the appropriate django-tabular-permissions version and
- Document each app & model

Also TODO:
- Some models aren't needed, filter them out of the query set
- Do the same for TenantGroup model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant