Overdue deterministic fix #1819
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the OverdueStateApplicator logic, a lot of actions can be triggered on different sub-systems: * Cancellation of subscriptions * Transition into / out of AUTO_INVOICE_OFF * New blocking states set These actions potentially send events on the bus that invoice will react to, and the timing of these actions can make the resulting invoice(s) non-deterministic. This patch: * Delays sending AUTO_INVOICE_OFF events until after the new blocking states are set * Sets and unsets AUTO_INVOICE_OFF around the whole overdue logic when cancelling subscriptions Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Make sure that in case of rollbacks (potentially wrong) mappings are not cached. Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here.