This repository has been archived by the owner on Sep 19, 2023. It is now read-only.
Created a 'pos_check' gateway. #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merce 'cheque' gateway marks orders as 'on-hold'. This one marks them as completed.
* 'master' of https://github.com/kilbot/WooCommerce-POS: Add listener for card scan
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is necessary to have a 'pos_check' gateway even though there is a 'cheque' gateway built into woocommerce. This is because the use cases are different. It is completely logical for the built in gateway to set orders to 'on-hold' as the check would have to be mailed in. For a POS, that is a very inconvenient way to handle it. A check will always be provided at the moment of the sale, therefore it should be marked as completed immediately.
Because of these differences, the built in gateway will never be changed, and most likely, neither will a filter be introduced into woocommerce to make this behavior tweakable.