MBL-1374: Handle long add-on names on late pledge confirmation page #2055
+36
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| override func viewWillLayoutSubviews() { | ||
| super.viewWillLayoutSubviews() | ||
|
|
||
| self.tableViewContainerHeightConstraint?.constant = self.tableView.intrinsicContentSize.height |
There was a problem hiding this comment.
This constraint needed to be updated; otherwise it squashes the table.
| } | ||
|
|
||
| private func rootStackViewStyle(_ isAccessibilityCategory: Bool) -> (StackViewStyle) { | ||
| let alignment: UIStackView.Alignment = (isAccessibilityCategory ? .center : .top) | ||
| let axis: NSLayoutConstraint.Axis = (isAccessibilityCategory ? .vertical : .horizontal) | ||
| let distribution: UIStackView.Distribution = (isAccessibilityCategory ? .equalSpacing : .fill) | ||
| let distribution: UIStackView.Distribution = (isAccessibilityCategory ? .equalSpacing : .fillProportionally) |
There was a problem hiding this comment.
This is the only behavioral change in this function; the rest is just making the Prelude-y bits less Prelude-y. (Which had the benefit of fixing a warning about type check taking 2000 ms!)
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| self.titleLabel.preferredMaxLayoutWidth = self.titleLabel.frame.size.width | ||
| super.layoutSubviews() |
There was a problem hiding this comment.
Ugly little hack to make multi-line labels work properly in automatically sized cells.
amy-at-kickstarter
force-pushed
the
bug/adyer/MBL-1374/late-pledge-titles-overflow
branch
from
aee4baf
to
dcfa58c
Compare
amy-at-kickstarter
requested review from
a team and
ifosli
and removed request for
a team
ifosli
approved these changes
May 9, 2024
amy-at-kickstarter
deleted the
bug/adyer/MBL-1374/late-pledge-titles-overflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
In the summary view for late pledge confirmation,
🤔 Why
Long add-on names would break the summary view:
👀 See
Here's the same project, fixed:
Here's an example of it working, with a very long hard-coded string:
As well as working with the largest font size:
